Repository navigation
Make XsltStepTest DOCTYPE check locale-independent - #482
Merged
tonygermano merged 1 commit intoOct 12, 2026
Merged
tonygermano merged 1 commit into
tonygermano merged 1 commit into
Conversation
…gine#476) The JDK translates the "DOCTYPE is disallowed" message, so the test failed on non-English locales. Check the feature URI instead, which appears in every translation. Signed-off-by: Ezio Caffi <ezio.caffi@gmail.com>
e210
marked this pull request as ready for review
October 10, 2026 21:49
e210
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1,
ssrowe and
tonygermano
October 10, 2026 21:49
Contributor
|
Could you also require the parse error itself? For example: String s = String.valueOf(e);
assertTrue(s, s.contains("SAXParseException") && s.contains("disallow-doctype-decl")); |
Member
@NicoPiel This is the stack trace (in French). The actual exception is a |
tonygermano
approved these changes
Oct 11, 2026
tonygermano
left a comment
tonygermano
left a comment
Member
There was a problem hiding this comment.
Thanks! I appreciate someone running the builds in other locales and submitting fixes.
Maybe we'll have actual i18n support at some point 😄
pacmano1
approved these changes
Oct 11, 2026
pacmano1
left a comment
pacmano1
left a comment
Contributor
There was a problem hiding this comment.
Heads up for anyone repeating this: switching locale between runs doesn't re-run the tests. Gradle doesn't count the locale as a test input, so :server:test comes back UP-TO-DATE and BUILD SUCCESSFUL without running anything. Add --rerun:
./gradlew -Duser.language=it -Duser.country=IT :server:test --tests '*XsltStepTest' --rerun
Contributor
|
@tonygermano I agree, but the additional work required is negligible. Still, gonna approve. |
NicoPiel
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JDK kindly translates "DOCTYPE is disallowed", so on an Italian machine the test got "DOCTYPE non è consentito" and gave up. Now it checks for
disallow-doctype-decl, the feature URI that every translation keeps as is. No locale forcing needed.Passes on it, tr, en and ja.
Part of #476 (the CI scenario is still to come)